Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 32 bit precision for the beauty if using a newer USD build #9

Closed
sirpalee opened this issue Nov 14, 2019 · 1 comment · Fixed by #309
Closed

Use 32 bit precision for the beauty if using a newer USD build #9

sirpalee opened this issue Nov 14, 2019 · 1 comment · Fixed by #309
Assignees
@sirpalee
Labels
enhancement New feature or request render delegate Related to the Arnold Render Delegate
Projects
Sprint 20 Sprint 21

Comments

@sirpalee
Copy link
Contributor

Newer USD expanded the HdxCompositor to allow for non-8 bit int buffers for the color. We should take advantage of this and use f32 for beauty.

Related to: #8
@sirpalee sirpalee added the enhancement New feature or request label Nov 14, 2019
@sirpalee sirpalee mentioned this issue Nov 15, 2019
Closed
@nrusch
Copy link
Contributor

nrusch commented Nov 15, 2019

I think maybe the render delegate should respect the HdAovDescriptor definition from the task controller...

@sirpalee sirpalee added the render delegate Related to the Arnold Render Delegate label Nov 29, 2019
@sirpalee sirpalee changed the title [Render Delegate] Use 32 bit precision for the beauty if using a newer USD build Use 32 bit precision for the beauty if using a newer USD build Nov 29, 2019
@sirpalee sirpalee added this to Needs triage in Ticket Triage via automation Mar 13, 2020
@sirpalee sirpalee added this to To do in Sprint 20 via automation Mar 20, 2020
@sirpalee sirpalee removed this from Needs triage in Ticket Triage Mar 20, 2020
@sirpalee sirpalee moved this from To do to In progress in Sprint 20 Mar 20, 2020
@sirpalee sirpalee self-assigned this Mar 20, 2020
@sirpalee sirpalee mentioned this issue Mar 20, 2020
Closed
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 27, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled.
da49b45 
Fixes Autodesk#8
Fixes Autodesk#9
Fixes Autodesk#4
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 27, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled.
eadf9b8 
Fixes Autodesk#8
Fixes Autodesk#9
Fixes Autodesk#4
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 27, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled.
36b920b 
Fixes Autodesk#8
Fixes Autodesk#9
Fixes Autodesk#4
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 27, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled.
2aea793 
Fixes Autodesk#8
Fixes Autodesk#9
Fixes Autodesk#4
@sirpalee sirpalee mentioned this issue Mar 27, 2020
Merged
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 27, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled.
4ad0fb8 
Fixes Autodesk#8
Fixes Autodesk#9
Fixes Autodesk#4
@kikou kikou added this to In progress in Sprint 21 Mar 27, 2020
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 29, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled.
fbedc1f 
Fixes Autodesk#8
Fixes Autodesk#9
Fixes Autodesk#4
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 29, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled.
ceb29f5 
Fixes Autodesk#8
Fixes Autodesk#9
Fixes Autodesk#4
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 30, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled.
c6243bb 
Fixes Autodesk#8
Fixes Autodesk#9
Fixes Autodesk#4
Sprint 21 automation moved this from In progress to Done Mar 30, 2020
sebastienblor pushed a commit that referenced this issue Mar 30, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled. (#309)
49afdf3 
Fixes #8
Fixes #9
Fixes #4
sebastienblor pushed a commit that referenced this issue Apr 7, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled. (#309)
18b62bc 
Fixes #8
Fixes #9
Fixes #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirpalee sirpalee

Labels
enhancement New feature or request render delegate Related to the Arnold Render Delegate
Projects
No open projects
Sprint 20
  
In progress
Sprint 21
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewriting how render buffers and aborted renders are handled. sirpalee/arnold-usd
2 participants
@sirpalee @nrusch