Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light/shadow links consider ignoreRoots as true by default #987

Closed
sebastienblor opened this issue Dec 28, 2021 · 0 comments
Closed

Light/shadow links consider ignoreRoots as true by default #987

sebastienblor opened this issue Dec 28, 2021 · 0 comments
Assignees
@sebastienblor
Labels
bug Something isn't working procedural Related to the Arnold Procedural user Reported by a user
Projects
Sprint 62

Comments

@sebastienblor
Copy link
Collaborator

Describe the bug
In the CollectionAPI for light links and shadow links, the procedural is currently assuming that when ignoreRoots is disabled, it is true by default.
That's wrong based on the collection api schema, it should default to false. This is leading to wrong results (as opposed to the render delegate which is correct)
@sebastienblor sebastienblor added bug Something isn't working procedural Related to the Arnold Procedural labels Dec 28, 2021
@sebastienblor sebastienblor self-assigned this Dec 28, 2021
sebastienblor added a commit to sebastienblor/arnold-usd that referenced this issue Dec 28, 2021
@sebastienblor
Light and shadow links default ignoreRoots to false Autodesk#987
c83d291
@sebastienblor sebastienblor mentioned this issue Dec 28, 2021
Merged
@sirpalee sirpalee added this to To do in Sprint 62 via automation Dec 28, 2021
@sirpalee sirpalee moved this from To do to Reviewer approved in Sprint 62 Dec 28, 2021
sebastienblor added a commit that referenced this issue Dec 28, 2021
@sebastienblor
Light and shadow links default ignoreRoots to false #987 (#988)
38e024a
sebastienblor added a commit that referenced this issue Dec 29, 2021
@sebastienblor @sirpalee
Merge fix-7.0.0 into master (#991)
d74356b 
* Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. (#881)

* Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions.

Fixes #880
Fixes #772

* Only call AiBegin/AiEnd in the delegate if no arnold session is active #884 (#885)

* Support render tags in the render delegate. (#883)

* Checking for render tags.
* Tracking render tags for shapes.
* Improving render tag tracking.
* Interrupt before disabling nodes.
* Renaming render tag handling functions and moving the core logic to a separate function.
* Tracking the point instancer's render tag.

Fixes #843

* Improving conversions between integer types. (#889)

* Setting unsigned int parameters from int. (#887)

* Adding more tests and conversions. (#887)

* Passing render session to AiDeviceAutoSelect. (#903)

Fixes #902

* Avoid calling AiRenderBegin when render is already running. (#901)

Fixes #900

* Fixing the use of AI_TYPE_INT AOVs and removing a warning when setting blend_opacity. (#908)

Fixes #905

* Setting the returned version to default in the Sdr plugin. (#907)

Fixes #906

* Using GetVolumeShader if native rprim is volume. (#920)

Fixes #915

* Fix pointInstancer and prototypes visibilities (#916)

* Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. (#881) (#882)

Fixes #880
Fixes #772

* Updating master with changes from the fix branch (#886)

* Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. (#881)

* Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions.

Fixes #880
Fixes #772

* Only call AiBegin/AiEnd in the delegate if no arnold session is active #884 (#885)

* Support render tags in the render delegate. (#883)

* Checking for render tags.
* Tracking render tags for shapes.
* Improving render tag tracking.
* Interrupt before disabling nodes.
* Renaming render tag handling functions and moving the core logic to a separate function.
* Tracking the point instancer's render tag.

Fixes #843

Co-authored-by: Sebastien Blaineau-Ortega <sebastien.blaineau.ortega@autodesk.com>

* Merging fix branch to master. (#894)

* Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. (#881)

* Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions.

Fixes #880
Fixes #772

* Only call AiBegin/AiEnd in the delegate if no arnold session is active #884 (#885)

* Support render tags in the render delegate. (#883)

* Checking for render tags.
* Tracking render tags for shapes.
* Improving render tag tracking.
* Interrupt before disabling nodes.
* Renaming render tag handling functions and moving the core logic to a separate function.
* Tracking the point instancer's render tag.

Fixes #843

* Improving conversions between integer types. (#889)

* Setting unsigned int parameters from int. (#887)

* Adding more tests and conversions. (#887)

Co-authored-by: Sebastien Blaineau-Ortega <sebastien.blaineau.ortega@autodesk.com>

* Merging fix-7.0.0 to master (#909)

* Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. (#881)

* Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions.

Fixes #880
Fixes #772

* Only call AiBegin/AiEnd in the delegate if no arnold session is active #884 (#885)

* Support render tags in the render delegate. (#883)

* Checking for render tags.
* Tracking render tags for shapes.
* Improving render tag tracking.
* Interrupt before disabling nodes.
* Renaming render tag handling functions and moving the core logic to a separate function.
* Tracking the point instancer's render tag.

Fixes #843

* Improving conversions between integer types. (#889)

* Setting unsigned int parameters from int. (#887)

* Adding more tests and conversions. (#887)

* Passing render session to AiDeviceAutoSelect. (#903)

Fixes #902

* Avoid calling AiRenderBegin when render is already running. (#901)

Fixes #900

* Fixing the use of AI_TYPE_INT AOVs and removing a warning when setting blend_opacity. (#908)

Fixes #905

* Setting the returned version to default in the Sdr plugin. (#907)

Fixes #906

Co-authored-by: Sebastien Blaineau-Ortega <sebastien.blaineau.ortega@autodesk.com>

* Updating changelog and readme for Arnold 7. (#898)

Fixes #897

* Fix pointInstancer and prototypes visibilities #458

* Updating changelog and readme for Arnold 7. (#898)

Fixes #897

* Fix pointInstancer and prototypes visibilities #458

Co-authored-by: Pal Mezei <sirpalee@users.noreply.github.com>

* Update tests for Arnold 7. (#922) (#923)

* Don't write the default color manager node to usd #924 (#925)

* Remap curves primvars (#926)

* Remap curves primvars values #921

* Simplify calls to RemapCurvesVertexPrimvars #921

* Changing the default descriptor returned for AOVs. (#919)

Fixes #918

* Apply point instancer matrix to all instances #928 (#929)

Fixes #928

* Set product metadata. (#933)

Fixes #932

* Add support for primvars on instances #944 (#948)

* Add render session to AiMsg calls #953 (#954)

* Call AiResolveFilePath with procedural type #942 (#952)

* Support USD 21.11 (#958)

* Support USD 21.11

* Port schemas to USD 21.11 #957

* Fix build of usd_imaging with USD 21.11 #957 (#961)

* Fix build of usd_imaging with USD 21.11 #957

* Mising ifdefs for older versions of USD #957

* Fix primvars on instanceable prims #944 (#965)

* Extend the skinning baking interval to the surrounding integer frames #951 (#979)

* Support curves UVs #975 (#977)

* Light and shadow links default ignoreRoots to false #987 (#988)

* Read USD builtin normals on meshes #962 (#986)

* Read UsdLuxShadowAPI parameters #945 (#990)

Co-authored-by: Pal Mezei <sirpalee@users.noreply.github.com>
@sebastienblor sebastienblor moved this from Reviewer approved to Done in Sprint 62 Dec 29, 2021
@sebastienblor sebastienblor added the user Reported by a user label Jan 7, 2022
@sebastienblor sebastienblor mentioned this issue Feb 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastienblor sebastienblor

Labels
bug Something isn't working procedural Related to the Arnold Procedural user Reported by a user
Projects
No open projects
Sprint 62
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sebastienblor