Support "vertex" UV coordinates on curves in the render delegate #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
In the render delegate, we were only supporting "uniform" primvars to turn the "st" primvars into builtin uvs.
But Solaris seems to output them as "varying" primvars, where each curve vertex has a value, but with a value that is identical for each vertex of the curve. In this PR we support this use case, by considering the uv coordinate at the strand root (first vertex), and applying that on the whole strand.
I added test_1435 to exercise this in the procedural. But I had to fix #1579 because the houdini scene had no width defined.
Issues fixed in this pull request
Fixes #1435
Fixes #1579