Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregation not working in ”pull request usage” chart #120

Closed
pluehne opened this issue Feb 12, 2018 · 0 comments · Fixed by #121
Closed

Aggregation not working in ”pull request usage” chart #120

pluehne opened this issue Feb 12, 2018 · 0 comments · Fixed by #121
Assignees
Labels

Comments

@pluehne
Copy link
Contributor

pluehne commented Feb 12, 2018

Despite the fact that I implemented a generalized aggregation framework and enabled monthly data aggregation for the pull request usage chart. This isn’t visible in the live demo, whose TSV file has monthly data only. On a real appliance, where daily data is recorded, this becomes apparent:

screenshot from 2018-02-12 15-03-31

Apparently, I introduced this bug in #105. The code responsible for aggregation is now only called for multiview charts (but the pull request usage chart has a single view currently).

@pluehne pluehne added the bug label Feb 12, 2018
@pluehne pluehne self-assigned this Feb 12, 2018
@pluehne pluehne added this to To Do in Hubble Enterprise 0.3.0 via automation Feb 12, 2018
@pluehne pluehne moved this from To Do to In Progress in Hubble Enterprise 0.3.0 Feb 13, 2018
Hubble Enterprise 0.3.0 automation moved this from In Progress to Done Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant