Multiple views per chart and view switchers in action bar #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds CSS support for button bars, which contain multiple buttons attached to each other.
This extracts the sorting routine from the aggregation method and applies it to all time data and not just when aggregation is enabled, which was the case before.
This commit implements the new option “views.” With this array, multiple views can be specified, which each have a unique configuration. For instance, one view could show the daily data of the last two months and another one weekly aggregated data for the last two years. The implementation ensures that former configurations that don’t make use of views still work as before.
With this change, all history charts that provide multiple views in their configurations automatically get a view switcher in the corresponding action bar next to the chart. This places the view switcher on the left side of the action bar, while the data download button is moved to the right side.
This adds three views (last two months, last two years, all data) to the “pull requests (total)” chart, for which a view switcher is automatically created.
To demonstrate the new view switcher, more demo data is needed to show meaningful differences between the views.
|
@larsxschneider: I just noticed that our reports truncate data after two years. Hence, the all view doesn’t really make sense, as it will show the same data as the two years view. I’d suggest that we stop truncating data after 2 years, as we now have the option to show this period via the view switcher 😄. However, that’s something we should address in another pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements support for multiple detail views per chart (which can be configured through the
data-configattribute in HTML) along with a handy view switcher in the action bar. Each view has its own configuration. For instance, there can be one view showing the daily data recorded in the last two months, while another view shows the weekly aggregated data over the last two years.This pull requests exemplarily adds support for the view switcher to the pull requests (total) chart, while compatibility with the older configuration format is ensured.
I recommend reviewing this pull request commit by commit.
See the screenshots below to see how this looks in action 🙂.