Fix error with empty chart views #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When aggregating over only few data points, the weekly-aggregated views might end up empty. This led to an error, because the chart generation relied on the data not to be empty. This adds a corresponding check, which prevents the error and shows an empty chart as expected. Instead of showing users empty charts, views with no data should be hidden from the users. This will be addressed separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When aggregating over only few data points, the weekly-aggregated views might end up empty. This led to an error, because the chart generation relied on the data not to be empty.
This adds a corresponding check, which prevents the error and shows an empty chart as expected.
Instead of showing users empty charts, views with no data should be hidden from the users. This will be addressed separately (tracked in issue #133).
Note that with the meek amounts of demo data that we currently have, many chart views in the interactive demo end up empty. This should be addressed as suggested in #132.
Fixes #128.