Rewrite headers on every update #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit, every single update will cause the data file headers to be rewritten to their defaults. In this way, we can easily change column labels in the data files in the future without having to worry about empty charts due to the inconsistent naming scheme (which causes the dashboard not to match the data series with the columns appropriately). I don’t consider this a change that could accidentally break data by, for instance, switching the meaning of columns in the future. The reason is that we have the data schema mechanism in place to deal with cases where we would like to make deeper changes to the data format that would require a data migration.
pluehne
force-pushed
the
patrick/fix-headers
branch
from
117d8b3
to
15baa42
Compare
This was referenced Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit, every single update will cause the data file headers to be rewritten to their defaults.
In this way, we can easily change column labels in the data files in the future without having to worry about empty charts due to the inconsistent naming scheme (which causes the dashboard not to match the data series with the columns appropriately).
I don’t consider this a change that could accidentally break data by, for instance, switching the meaning of columns in the future. The reason is that we have the data schema mechanism in place to deal with cases where we would like to make deeper changes to the data format that would require a data migration.