Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IfcSpatialElement #23

Closed
dvrvb opened this issue Aug 27, 2018 · 2 comments
Closed

IfcSpatialElement #23

dvrvb opened this issue Aug 27, 2018 · 2 comments

Comments

@dvrvb
Copy link

dvrvb commented Aug 27, 2018

2018-08-27 IfcSpatialElement.zip
R2019.1 / regular 19.1 exporter version vs. current-Github-master-version

Compared to the "regular" 19.1 exporter version, there seems to be an issue with the export of the entities of the class IfcSpatialElement in the current-Github-master-version.

Situation:
Model In-Place cubes (no modeltext this time, just cubes) with IfcExportAs =

  • IfcExternalSpatialElement
  • IfcSite
  • IfcBuilding
  • IfcBuildingStorey
  • IfcSpace / IfcSpaceType
  • IfcSpatialZone / IfcSpatialZoneType

IFC4RV export:

  • with the regular 19.1 exporter version: these entities are exporting OK.
  • with the current-Github-version: these entities are exporting, but are not visible anymore in the FZKViewer or in BIM Vision. If I look into the IFC-model with Notepad, I notice a lot of $-signs in the definition attributes (see screenshot in the ZIP-file)

Attached: the RVT-model and the IFC4RV exports of both versions of the exporter.

@dvrvb
Copy link
Author

dvrvb commented Oct 6, 2018

test with current version in DEV-branch (compared to the regular exporter v19.1)
2018-10-06 IfcSpatialElement.zip

with regular exporter v19.1: all of them are exported as the matching Entity/TypeClass:
some remarks:

  1. IfcSite/IfcBuilding/IfcBuildingStorey should in my opinion be exported as:
  • or IfcBuildingElementProxy (in the case they are considered as illegal entityclasses placed on a buildingstorey)
  • or as the geometry in the spatial structure (compared how the geometry of a topography is used for generating the geometry of IfcSite)
  1. since IfcExternalSpatialElement is not within the scope of IFC4RV, it also should be exported as IfcBuildingElementProxy

with current version in DEV-branch:
IFC2x3CV2.0
Only 3 cubes are exported and visible as IfcBuildingElementProxy. The others are present in the IFC-model, but not visible.
I would expect that all of them (except IfcSpace/IfcSpaceType) are exported as IfcBuildingElementProxy.
IfcSpace/IfcSpaceType should be exported as their matching Entity/TypeClass (as they were in the export with the regular exporter v19.1)

IFC4RV1.2
None of them are visible, but they are present in the IFC-model.
I would expect that all of them (except IfcSpace/IfcSpaceType IfcSpatialZone/IfcSpatialZoneType) are exported as IfcBuildingElementProxy.
IfcSpace/IfcSpaceType IfcSpatialZone/IfcSpatialZoneType should be exported as their matching Entity/TypeClass (as they were in the export with the regular exporter v19.1)

Regards,
Dirk
image

WawanSolihin added a commit that referenced this issue Nov 17, 2018
…patial Element (Issue #23)

However in IFC4RV or DTV, there is a fixed list of valid entities that will be enforced, entity such as IfcExternalSpatialElement will be exported as IfcBuildingElementProxy, unless the generic IFC4 option is used.
@dvrvb
Copy link
Author

dvrvb commented Nov 18, 2018

I'll close this issue, and I'll continue at #68 for issues concerning Entity/TypeClasses and PredefinedTypes.

@dvrvb dvrvb closed this as completed Nov 18, 2018
WawanSolihin added a commit that referenced this issue Sep 4, 2021
…patial Element (Issue #23)

However in IFC4RV or DTV, there is a fixed list of valid entities that will be enforced, entity such as IfcExternalSpatialElement will be exported as IfcBuildingElementProxy, unless the generic IFC4 option is used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant