[#198] Replace urlencode/urldecode with rawurlencode/rawurldecode

Automattic · Jan 30, 2018 · 9806b14 · 9806b14
1 parent cc36104
commit 9806b14
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/co-authors-plus.php b/co-authors-plus.php
@@ -767,8 +767,8 @@ function coauthors_set_post_author_field( $data, $postarr ) {
 		// This action happens when a post is saved while editing a post
 		if ( isset( $_REQUEST['coauthors-nonce'] ) && isset( $_POST['coauthors'] ) && is_array( $_POST['coauthors'] ) ) {
 
-			// urlencode() is for encoding coauthor name with special characters to compare names when getting coauthor.
-			$author = urlencode( sanitize_text_field( $_POST['coauthors'][0] ) );
+			// rawurlencode() is for encoding coauthor name with special characters to compare names when getting coauthor.
+			$author = rawurlencode( sanitize_text_field( $_POST['coauthors'][0] ) );
 
 			if ( $author ) {
 				$author_data = $this->get_coauthor_by( 'user_nicename', $author );
@@ -1137,7 +1137,7 @@ public function ajax_suggest() {
 		if( empty( $authors ) ) echo apply_filters( 'coauthors_no_matching_authors_message', 'Sorry, no matching authors found.');
 
 		foreach ( $authors as $author ) {
-			echo esc_html( $author->ID . ' | ' . $author->user_login . ' | ' . $author->display_name . ' | ' . $author->user_email . ' | ' . urldecode( $author->user_nicename ) ) . "\n";
+			echo esc_html( $author->ID . ' | ' . $author->user_login . ' | ' . $author->display_name . ' | ' . $author->user_email . ' | ' . rawurldecode( $author->user_nicename ) ) . "\n";
 		}
 
 		die();