Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avatars for guest authors #24

Closed
danielbachhuber opened this issue May 3, 2012 · 1 comment
Closed

Avatars for guest authors #24

danielbachhuber opened this issue May 3, 2012 · 1 comment
Assignees
@danielbachhuber
Milestone
v3.0

Comments

@danielbachhuber
Copy link
Contributor

We should let admins upload images as avatars for guest authors, and then override the default value of get_avatar()
@ghost ghost assigned danielbachhuber May 3, 2012
danielbachhuber added a commit that referenced this issue May 3, 2012
@danielbachhuber
Rudimentary avatar support for Guest Authors leveraging featured images
39066e6 
This needs improvement in a couple of regards:
* Support for multiple avatar image sizes. I'm thinking we should register a few of the common ones.
* Reverse lookups against postmeta are bad. We should have a better way of seeing whether the `$id_or_email` value needs to be overridden

See #24
@danielbachhuber
Copy link
Contributor Author

This is mostly functional but a couple of improvements need to be made:

  • Avoid using a SQL query to do a reverse lookup on the postmeta field every time get_avatar() is requested with an email
  • Support more sizes than just 32x32

danielbachhuber added a commit that referenced this issue May 15, 2012
@danielbachhuber
Sometimes an entire object is passed to get_avatar as an ID or email.…
af8177c 
… We should research whether this is appropriate use we need to accomodate for

See #24
danielbachhuber added a commit that referenced this issue Nov 21, 2012
@danielbachhuber
Register guest author avatar sizes when the class is instatiated, as …
799c2fa 
…the class is instatiated on 'init' and 'after_setup_theme' has already fired

See #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielbachhuber danielbachhuber

Labels
None yet
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
1 participant
@danielbachhuber