Update to use cached functions #368
Conversation
As part of a VIP GO code review, we were asked to update our codebase to use cached functions. We updated our controlled code, and are working to submit PRs to codebases we don't directly control
| $terms = wp_get_object_terms( $post_id, $this->coauthor_taxonomy, array( 'fields' => 'ids' ) ); | ||
| return ! empty( $terms ) && ! is_wp_error( $terms ); | ||
| $term_objects = get_the_terms( $post_id, $this->coauthor_taxonomy ); | ||
| $terms = ( ! is_wp_error( $term_objects ) ) ? wp_list_pluck( $term_objects, 'term_id' ) : array(); |
There was a problem hiding this comment.
The list pluck is unnecessary here. We can just do return ! is_wp_error( $term_objects ) && ! empty( $term_objects )
|
I think we should drop the uses of |
|
For the instances where we're using For the other usage by slug, I'm fine with the check for the existence of |
|
Going through some old open PRs of mine. . .is this worth merging with some changes or should I close this? |
|
Closing as |
As part of a VIP GO code review, we were asked to update our codebase to use cached functions. We updated our controlled code, and are working to submit PRs to codebases we don't directly control