Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSS to hide the Block Editor's Author label + select #630

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

mjangda
Copy link
Member

@mjangda mjangda commented Dec 7, 2018

This is a pretty big hack :)

With 5.0, we end up with both Core's author input and the Co-Authors Plus metabox which is going to be cause for confusion (see #614).

It would be better to remove the inputs completely rather than hiding them (via javascript or hooking directly into Block Editor [1]) but this is a good start to help reduce that confusion.

[1] May need some new hooks in the editor to make this possible easily (i.e. without hacks :)).

This is a pretty big hack :) It would be better to remove the inputs completely rather than hiding them (via javascript or hooking directly into Gutenberg) but this is a good start.
@mjangda mjangda changed the title Use CSS to hide Core's Author label + select Use CSS to hide the Block Editor's Author label + select Dec 7, 2018
@mjangda
Copy link
Member Author

mjangda commented Dec 7, 2018

Even better fix in the future would be to replace the core input with the co-authors plus input and have it nicely integrated with the Block Editor.

@rebeccahum rebeccahum merged commit fe6938e into master Dec 7, 2018
@rebeccahum rebeccahum deleted the fix/block-editor-compat branch December 7, 2018 16:54
@mjangda mjangda mentioned this pull request Dec 7, 2018
rebeccahum added a commit that referenced this pull request Mar 26, 2019
Use CSS to hide the Block Editor's Author label + select
@scofennell
Copy link
Contributor

This CSS no longer targets the post_author selector.

/** Block Editor Hack for 5.0: Hide the core author input **/ .block-editor label[for^="post-author-selector-"], .block-editor select[id^="post-author-selector-"] { display: none; }

The markup in Gutenberg has changed:

Screen Shot 2021-05-20 at 10 36 44 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants