FIX: Handle display name with special chars

[nielslange]

Fixes #370

Changes

Allow users and guest users to use special characters in the display name.

Steps to test

1. Create a guest author with a special character in the display name, e.g. Jane | Doe
2. Open an existing post and add that guest author to it
3. Verify that the avatar/Gravatar is broken
4. Check out this PR
5. Refresh the post page
6. Add the guest author again
7. Verify that the avatar/Gravatar is visible

Screenshots

Before:

After:

[htdat]

I commented a trick to workaround below. However, I think if possible, we may consider switching to JSON like what's recommended in #370

[htdat]

LGTM given @nielslange's explanation here #775 (comment)

[rebeccahum]

During testing, it seems to break for me:

My testing steps:

1. Create guest author with display name "Test | Pipe"
2. Go to a post
3. Assign "Test | Pipe" author.

Edit: You can try to assign any author and it gives a broken row.

[nielslange]

@rebeccahum I'm afraid, I'm unable to reproduce what you;'re seeing on your end. On my end, when using a pipe, the guest author is visible as expected. I tested that both with my existing testing site and with a brand-new testing site.

[rebeccahum]

On a clean WP install, I'm still seeing the same issue:

WP 5.7
PHP 7.4
Chrome

[nielslange]

@rebeccahum Do you see any errors in the console? Strange enough, I'm using the exact environment and on my end, the fix works as expected. Without seeing what you are seeing, it's a bit tricky to apply changes.

[rebeccahum]

No console errors that stand out for me. Issue is only prevalent when I checkout this PR.

@htdat do you run into the same issue as me in testing?

[htdat]

@htdat do you run into the same issue as me in testing?
WP 5.7
PHP 7.4
Chrome

Works well for me. I am using the same env.
Maybe providing the content of the relevant AJAX response is helpful? Here is mine:

115 ∣ test-pipe ∣ Test | Pipe ∣  ∣ test-pipe ∣ http://0.gravatar.com/avatar/?s=96&d=mm&r=g 

[rebeccahum]

Ah, looks like the issue was browser cache enabled — it goes away when I disable it.

[rebeccahum]

LGTM 👍

[nielslange]

Ah, looks like the issue was browser cache enabled — it goes away when I disable it.

I'm glad to hear that it;s working on your end now.