bring actions setup in line with other plugins #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryJones
approved these changes
Jun 26, 2021
htdat
reviewed
Jun 28, 2021
Comment on lines
+64
to
+67
| # Check the code-style consistency of the PHP files. | ||
| # - name: Check PHP code style | ||
| # continue-on-error: true | ||
| # run: vendor/bin/phpcs --report-full --report-checkstyle=./phpcs-report.xml |
There was a problem hiding this comment.
@trepmal
This is how Edit Flow is implementing to check PHPCS for just diff files.
Edit-Flow/.github/workflows/php-tests.yml
Lines 56 to 60 in c7e3fa7
Ideally, we run PHPCS for all PHP files, but for old plugins like this, it's not productive to detect and fix all PHPCS errors. So I think this approach should be still kept though there may be a better way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to bring some GitHub actions setup inline with other Automattic & VIP plugins