Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables/VariableAnalysis: remove the sniff #776

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Aug 24, 2023

Follow up after the deprecation in PR #450.

  • Remove the sniff.
  • Remove the error silencing related to the deprecation from the ruleset.

Fixes #496

@jrfnl jrfnl added this to the 3.0.0 milestone Aug 24, 2023
@jrfnl jrfnl requested a review from a team as a code owner August 24, 2023 15:03
Follow up after the deprecation in PR 450.

* Remove the sniff.
* Remove the error silencing related to the deprecation from the ruleset.
@GaryJones GaryJones force-pushed the 3.0/fix/496-remove-variableanalysis-sniff branch from 67aae6d to 09cab10 Compare August 24, 2023 15:12
Copy link
Contributor

@GaryJones GaryJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GaryJones GaryJones merged commit ad61b64 into develop Aug 24, 2023
32 checks passed
@GaryJones GaryJones deleted the 3.0/fix/496-remove-variableanalysis-sniff branch August 24, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove WordPressVIPMinimum.Variables.VariableAnalysis
2 participants