Classes/DeclarationCompatibility: sync with WP Core #799
Conversation
While looking at this sniff for something unrelated, I started wondering if the signature definitions were still in line with WP Core. Turned out they were not, though with the current checks being done in the sniff, this wasn't necessarily problematic (though it should have been, but that's for another PR). Also see the [additional notes I've added to the review ticket](#507 (comment)). Refs: * https://developer.wordpress.org/reference/classes/wp_widget/wp_widget/ * https://developer.wordpress.org/reference/classes/walker/start_el/ * https://developer.wordpress.org/reference/classes/walker/end_el/ * https://developer.wordpress.org/reference/classes/walker/unset_children/
|
When did those changes happen in WP core, and would this sniff, in theory, need to differentiate for folks running this sniff on a before and after version of WP core? |
I know a lot of variable renaming has been happening since PHP 8.0 as, even though WP doesn't support named parameters, it did bring more focus on using better parameter names. I can do a git blame to figure out exactly when, but to be honest, it's irrelevant as parameter names are not checked by the sniff (as I mention in the description above + in the comments on the other ticket). So, while this commit improves the information contained in the sniff, it has no impact on the functionality of the sniff. |
While looking at this sniff for something unrelated, I started wondering if the signature definitions were still in line with WP Core.
Turned out they were not, though with the current checks being done in the sniff, this wasn't necessarily problematic (though it should have been, but that's for another PR).
Also see the additional notes I've added to the review ticket.
Refs: