Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Setup CSS is Bleeding In All Admin Pages #728

Closed
turtlepod opened this issue Jul 26, 2016 · 0 comments
Closed

Admin Setup CSS is Bleeding In All Admin Pages #728

turtlepod opened this issue Jul 26, 2016 · 0 comments
Labels
[Pri] Low Cosmetic issue, low impact, easy workaround. [Type] Bug
Milestone
1.25.2

Comments

@turtlepod
Copy link
Contributor

What I Expected To Happen

setup.css is only needed on "setup page".

What Happened Instead

currently it's loaded in all admin pages.

here's the code from master branch:
https://github.com/Automattic/WP-Job-Manager/blob/master/includes/admin/class-wp-job-manager-setup.php#L76

current latest tag:
https://github.com/Automattic/WP-Job-Manager/blob/1.25.0/includes/admin/class-wp-job-manager-setup.php#L76

Steps to Reproduce the Bug

install plugin and check the admin page.
@chaselivingston chaselivingston added this to the 1.25.1 milestone Aug 5, 2016
@chaselivingston chaselivingston added the [Pri] Low Cosmetic issue, low impact, easy workaround. label Aug 5, 2016
donnchawp added a commit that referenced this issue Sep 30, 2016
@donnchawp
Stop setup.css loading except on the setup page
0d746c6 
Fixes #728
The file setup.css was enqueued on every Job Manager admin page
but this checks that the setup page is loaded before enqueuing it.
@donnchawp donnchawp mentioned this issue Sep 30, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Pri] Low Cosmetic issue, low impact, easy workaround. [Type] Bug
Projects
None yet
Milestone
1.25.2
Development

No branches or pull requests
3 participants
@adampickering @chaselivingston @turtlepod