Update .site-title styles instead of anchor in customizer script #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about title color? See: #677 |
|
Tested this out, and it works nicely. It's also how I tweaked in some themes. Thanks @samikeijonen for the issue and @joshmcrty for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #990 from @samikeijonen
Currently the customizer script visually hides/shows the
aelement inside the.site-title, which is not consistent with the actual CSS output by inc/custom-header.php, which hides/shows the.site-titleelement itself. This change makes the customizer consistent with the PHP changes.