Add HTML5 support for WordPress galleries. #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Man, you're quick! :) For themes we release to .org we try to maintain backwards compatibility with the latest two versions of WordPress. Let's keep styles for definition lists around for now, what do you think? |
|
Agree. See 9b0ae42 |
obenland
added a commit
that referenced
this pull request
Feb 27, 2014
_s: Add HTML5 support for WordPress galleries.
This was referenced Feb 28, 2014
|
I think we may want to add a comment in the CSS to remind devs why the definition list is in there. See: WPChill/decode-lite@5323e90 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://core.trac.wordpress.org/changeset/27302
Also a note: trailing commas with multiple-line arrays is a good idea and has a purpose. Trailing commas in inline array definitions doesn't have any benefits and looks weird :)