Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microformats 2 Changes #972

Closed
wants to merge 1 commit into from
Closed

Microformats 2 Changes #972

wants to merge 1 commit into from

Conversation

dshanske
Copy link

Because of the decision by core, and the comments in #860 , I wanted to do a basic mf2 adjustment of _s.

MF2 Parser (if you want to check pages) - http://pin13.net/mf2/

This covers the basic structure of microformats 2.

I also tried to move pagination out of entry-content/e-content...e-content should only have the content...admittedly that has been muddied by people using the content filter to put in everything from buttons to ads, so it is debatable in this case.

I didn't tackle marking up tags and categories...that is a bit more involved a rewrite as you have to mark each one up individually...I always felt using the before, after separators was a bit messy.

@karmatosed
Copy link
Contributor

Before we consider this the PR would need refreshing @dshanske.

@dshanske
Copy link
Author

Is the basic idea sound?

@dshanske
Copy link
Author

Refreshed I think

@Ruxton
Copy link

Ruxton commented Jul 19, 2016

@dshanske there's a couple of conflicts merging this with master at the moment.

@dshanske
Copy link
Author

@Ruxton, I believe that they are coding standards. I can fix for merge, but are there other issues?

@Ruxton
Copy link

Ruxton commented Jul 20, 2016

@dshanske

some new commits in archives.php updated taxonomy-description class to archive-description which causes a collision with your change to add p-summary

and the indenting in template-parts/content.php changed around line 15 causing your changes to be a collision too.

@dshanske
Copy link
Author

Should be addressed now.

@dshanske
Copy link
Author

dshanske commented Oct 1, 2016

Can we get feedback on this? I can keep refreshing it, but if there is no comment on whether it works for _s....

@Ruxton
Copy link

Ruxton commented Oct 3, 2016

fwiw, I took a fork of this and underscore.me site to my machine for building themes off this PR and have had no dramas.

@dshanske
Copy link
Author

dshanske commented Oct 5, 2016

So, it goes back to...if I refresh the pull, is it fit for merge?

@dshanske
Copy link
Author

Refreshed again.

@Ruxton
Copy link

Ruxton commented Oct 28, 2016

@davidakennedy @sixhours @karmatosed can we get some love on this PR?

@dshanske
Copy link
Author

I see that a lot of work is being done on _s. Can we see about this PR?

@davidakennedy
Copy link
Contributor

@dshanske Let's move broader discussion to #1113. The PRs should be used just for discussing code issues, etc.

@davidakennedy
Copy link
Contributor

Hi @dshanske! Thanks for your work here! Sorry this didn't get in. Closing in favor of the path outlined in #1268.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants