-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microformats 2 Changes #972
Conversation
Before we consider this the PR would need refreshing @dshanske. |
Is the basic idea sound? |
Refreshed I think |
@dshanske there's a couple of conflicts merging this with master at the moment. |
@Ruxton, I believe that they are coding standards. I can fix for merge, but are there other issues? |
some new commits in and the indenting in |
Should be addressed now. |
Can we get feedback on this? I can keep refreshing it, but if there is no comment on whether it works for _s.... |
fwiw, I took a fork of this and underscore.me site to my machine for building themes off this PR and have had no dramas. |
So, it goes back to...if I refresh the pull, is it fit for merge? |
29df812
to
8206827
Compare
Refreshed again. |
@davidakennedy @sixhours @karmatosed can we get some love on this PR? |
I see that a lot of work is being done on _s. Can we see about this PR? |
Because of the decision by core, and the comments in #860 , I wanted to do a basic mf2 adjustment of _s.
MF2 Parser (if you want to check pages) - http://pin13.net/mf2/
This covers the basic structure of microformats 2.
I also tried to move pagination out of entry-content/e-content...e-content should only have the content...admittedly that has been muddied by people using the content filter to put in everything from buttons to ads, so it is debatable in this case.
I didn't tackle marking up tags and categories...that is a bit more involved a rewrite as you have to mark each one up individually...I always felt using the before, after separators was a bit messy.