Adding License #989
Adding License #989
Conversation
|
Can't do that. Needs to be GPL2 or later. Look at Core's license file. |
|
Just looked at the code changes. Don't change the license! That's a problem. Just submit a PR with a proper license file and reference license.txt in the stylesheet. 😄 (Not suggesting this will be merged but it definitely needs serious consideration. I'd be in favor.) |
|
Is v2.1 okay? I also didn't get what you mean by changing license? It's the default LICENSE template from github and I just added the link to the file in readme and contributing texts. You mean Readme and Contributing shouldn't change? |
|
GPL3 and "GPL2 or later" have completely different implications. Let me find a decent license file. One sec. |
|
This is appropriate: https://themes.trac.wordpress.org/browser/twentyeleven/2.4/license.txt |
|
That's fine then it's v.2.0 not later. I will fix the PR now. |
|
No, it means that someone can develop either a GPL2 or GPL3 product when the license is "GPL2 or later". It doesn't mean that you cannot make a GPL3 product when the license is explicitly GPL2 or later. |
|
The only thing you need to be submitting is a license file and potentially a change to the license URL in style.css. You don't need to touch contributing or readme files at all. |
Pro-tip (not so much for here, but in general): |
|
Filing that in my pro-tip box. Nice. |
| @@ -15,7 +15,7 @@ My ultra-minimal CSS might make me look like theme tartare but that means less s | |||
| * A script at `js/navigation.js` that makes your menu a toggled dropdown on small screens (like your phone), ready for CSS artistry. It's enqueued in `functions.php`. | |||
| * 2 sample CSS layouts in `layouts/` for a sidebar on either side of your content. | |||
| * Smartly organized starter CSS in `style.css` that will help you to quickly get your design off the ground. | |||
| * Licensed under GPLv2 or later. :) Use it to make something cool. | |||
| * Licensed under [GPLv2](LICENSE) . :) Use it to make something cool. | |||
There was a problem hiding this comment.
This is wrong. Put it back to the way it was.
There was a problem hiding this comment.
The language "GPLv2 or later" is very important. It can't change.
|
@jrfnl Yes that's actually what I did. @philiparthurmoore Okay give me a minute. |
|
This is about 8 commits deep. It should be 1 with 1) an additional license file and 2) possibly a few adjustments to style.css and other files. It needs to be cleaned up. Let's try to get a clean PR in and figure out what a consensus is around including it. All these commits are making me jittery. Thanks for your persistence. :-) |
|
@philiparthurmoore lol I always regret it when I use github UI instead of cli. It doesn't have revert let me clone and revert back. |
|
It's all good. We can squash in GitHub. I'm just getting jittery. ;-) You need to change license URL here: https://github.com/Automattic/_s/blob/master/style.css |
|
@philiparthurmoore change that to the local file? I'm not sure like this you mean? |
|
LICENSE is fine. No slash needed. |
|
Thanks. It's probably worth letting this marinate for a bit so other people can get some eyes on it. 11 PM in Vietnam on Friday. Happy Weekend time. You're a champ for all these adjustments. |
|
Haha thanks and sorry for inconvenience. Happy weekend time from Malaysia! By the way if you know a way to remove those commits let me know. It's kinda annoying. |
|
Easy. We can squash them into one pre-merge. :-) Enjoy your evening! |
|
We need a change in readme.txt as well for this PR. |
|
While we are at it can we make these consistent? GPLv2 or later vs GNU General Public License v2 or later |
|
+1 for these changes |
Based on the issue created at #987
In the Readme the license was mentioned as
GPL v2 or laterso I added the latest one which is GPL v3.