Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard to see scrollbar when using darker background color. #18

Merged
merged 1 commit into from
Mar 21, 2012

Conversation

nulltask
Copy link
Contributor

Example: http://cl.ly/0R3J1E3B3p3z033N1j3q
Completely disappeared on #000 background.

Improved: http://cl.ly/0N0q3f3v1y3b2C103r0j
I added iOS style border by box-shadow. (legacy IE is unsupported.)

@rauchg
Copy link
Contributor

rauchg commented Mar 21, 2012

Genius. Thanks

rauchg added a commit that referenced this pull request Mar 21, 2012
Hard to see scrollbar when using darker background color.
@rauchg rauchg merged commit 60bb4e9 into Automattic:master Mar 21, 2012
@tj
Copy link

tj commented Mar 21, 2012

nice! why box-shadow here though? wouldn't border be fine?

@iammerrick
Copy link

I would think border would work but you would need to leverage rgba to get the transparency no?

@rauchg
Copy link
Contributor

rauchg commented Mar 21, 2012

I think it's the subtlety

@iammerrick
Copy link

Sure,

border: 1px solid rgba(255, 255, 255, 0.3)

Would probably yield a similar effect or something similar.

@nulltask
Copy link
Contributor Author

@guille
Thanks ;)

@visionmedia
First, I tried use border property. but I had some layout issue on calculating box size. then I also try outline property. but it doesn't support rounded rectangle for all browsers. box-shadow is better solution in this situation :)

@iammerrick
Copy link

Very cool.

@rauchg
Copy link
Contributor

rauchg commented Mar 21, 2012

Did you try adding border and substracting from the width/height ?

@rauchg
Copy link
Contributor

rauchg commented Mar 21, 2012

@iammerrick right but isn't the browser support of border + rgba equivalent to box-shadow ?
What would be cool however is a double border declaration, so that we get the fallback easily.

@iammerrick
Copy link

@guille Correct. However, a straight up white border might look a bit silly on older browsers. 1 line of css instead of 3 :-)

@nulltask
Copy link
Contributor Author

@iammerrick @guille
Yes, it's very subtlety :)

@nulltask
Copy link
Contributor Author

@guille
Yeah, I tried several times. however it was too complex to me :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants