Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an "undefined" function error #2

Merged
merged 1 commit into from
Jul 15, 2015
Merged

Fix an "undefined" function error #2

merged 1 commit into from
Jul 15, 2015

Conversation

jblz
Copy link
Member

@jblz jblz commented Jul 15, 2015

This applies the previous behavior (see #1) when working in an environment that does not support calling appendChild on a node. Said environment is not vulnerable to XSS because it's all treated as text-only.

This applies the previous behavior when working in an environment that does not support calling appendChild on a node. Said environment is not vulnerable to XSS because it's all treated as text-only.
@jblz jblz added the bug label Jul 15, 2015
@jblz jblz self-assigned this Jul 15, 2015
jblz added a commit that referenced this pull request Jul 15, 2015
@jblz jblz merged commit 030cba6 into master Jul 15, 2015
jblz added a commit to Automattic/jetpack that referenced this pull request Jul 15, 2015
This applies the previous behavior (see #2382) when working in an environment that does not support calling appendChild on a node (aka, the wp-admin "text" editor -- as opposed to the "visual" editor)
Said environment is not vulnerable to XSS because the post contents are not parsed by the browser's rendering engine.

Upstream: Automattic/atd-core#2
@jblz jblz deleted the fix/text-only-mode-err branch July 15, 2015 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant