Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly remember last url when multiple blocks are on the same page #217

Merged
merged 11 commits into from
Apr 18, 2023

Conversation

psrpinto
Copy link
Member

@psrpinto psrpinto commented Apr 17, 2023

When multiple blocks are on the same page, in different screens (e.g. different rooms), refreshing the page would not correctly bring each block to the screen where they were previously on.

This PR fixes that by introducing an instanceId attribute which is unique for each block on a page. We then use that instanceId to namespace the chatrix_last_url_hash property in local storage, so that it becomes chatrix_abc123_last_url_hash (where abc123 is the instanceId).

Note: For blocks created before this PR, the pages will need to be re-saved for the block(s) to get an instanceId.

Screen recording

Screen.Recording.2023-04-17.at.16.34.20.mov

Copy link
Member

@ashfame ashfame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@psrpinto psrpinto merged commit 30d13d6 into main Apr 18, 2023
@psrpinto psrpinto deleted the instanceId branch April 18, 2023 12:44
@psrpinto psrpinto mentioned this pull request Apr 19, 2023
@akirk
Copy link
Member

akirk commented Apr 26, 2023

@psrpinto researched using Gutenberg's own client ID (UUID for blocks) but the problem with that is that it changes between saves, the instanceID will remain the same throughout the block's life.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants