Merge pull request #188 from Automattic/add/no-constant-binary-expres…

…sion Add no-constant-binary-expression rule
Automattic · Nov 24, 2023 · a9c6a2e · a9c6a2e
2 parents 08c5fed + 09245dc
commit a9c6a2e
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 11 deletions.
diff --git a/__fixtures__/javascript.js b/__fixtures__/javascript.js
@@ -51,3 +51,5 @@ nonExistent();
 export function base64encode( str ) {
 	return Buffer.from( str ).toString( 'base64' );
 }
+
+export const constantBinary = x() || x() !== {};
diff --git a/__tests__/__snapshots__/check-fixtures.js.snap b/__tests__/__snapshots__/check-fixtures.js.snap
@@ -89,17 +89,6 @@ import { unusedEs6Import } from './stub/unusedEs6Import';
     "ruleId": "id-length",
     "severity": 1,
   },
-  {
-    "column": 10,
-    "endColumn": 11,
-    "endLine": 15,
-    "line": 15,
-    "message": "'x' is defined but never used.",
-    "messageId": "unusedVar",
-    "nodeType": "Identifier",
-    "ruleId": "no-unused-vars",
-    "severity": 2,
-  },
   {
     "column": 13,
     "endColumn": 14,
@@ -231,6 +220,17 @@ import { unusedEs6Import } from './stub/unusedEs6Import';
     "ruleId": "no-undef",
     "severity": 2,
   },
+  {
+    "column": 46,
+    "endColumn": 48,
+    "endLine": 55,
+    "line": 55,
+    "message": "Unexpected comparison to newly constructed object. These two values can never be equal.",
+    "messageId": "alwaysNew",
+    "nodeType": "ObjectExpression",
+    "ruleId": "no-constant-binary-expression",
+    "severity": 2,
+  },
 ]
 `;
 

diff --git a/configs/javascript.js b/configs/javascript.js
@@ -42,6 +42,7 @@ module.exports = {
 		'no-compare-neg-zero': 'error',
 		// 'no-cond-assign': 'error', // extended below
 		'no-const-assign': 'error',
+		'no-constant-binary-expression': 'error',
 		'no-constant-condition': 'error',
 		'no-control-regex': 'error',
 		'no-debugger': 'error',