Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make eslint and prettier work again #72

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Make eslint and prettier work again #72

merged 3 commits into from
Oct 5, 2021

Conversation

mirka
Copy link
Member

@mirka mirka commented Oct 4, 2021

Proposed changes

  • Install the missing eslint-plugin-eslint-comments plugin to make eslint run again.
  • Add ignore patterns to eslintrc.
  • Add ignore patterns to prettierignore.
  • Add yarn commands for eslint and prettier (following wp-scripts conventions).

To test

yarn lint:js --fix && yarn format should fix a bunch of issues, but only in directories we want.

@mirka mirka requested a review from johngodley October 4, 2021 03:31
@mirka mirka self-assigned this Oct 4, 2021
@mirka
Copy link
Member Author

mirka commented Oct 4, 2021

@johngodley As for commiting a batch fix of the existing lint/format errors, let's wait for a time that's convenient so we don't have to reconcile our PRs and whatnot.

@mirka mirka merged commit a522ec7 into trunk Oct 5, 2021
@mirka mirka deleted the eslint-prettier branch October 5, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant