Add fix for CSS override for Gutenberg's static mobile breakpoint #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gutenberg now adds a class to the html element. We want to remove the position without using `!important`, so that it doesn't also break previews, which change the `position` to another value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg adds a
position: staticto the page to stop it scrolling, but that's only relevant when the editor is full page like it is in Gutenberg. Ideally this is left up to the client.We need to override this as it's not possible to scroll the page at all otherwise.
We still want the static position when viewing previews, otherwise Gutenberg can't calculate the height.