Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP: Add Social Sharing Buttons #10314

Closed
supernovia opened this issue Oct 12, 2018 · 4 comments
Closed

AMP: Add Social Sharing Buttons #10314

supernovia opened this issue Oct 12, 2018 · 4 comments
Labels
AMP [Feature] Sharing Post sharing, sharing buttons [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@supernovia
Copy link

In the Jetpack forums, a user asked, "How do I make my social sharing buttons visible on AMP?" #

Steps to reproduce the issue

Load any page in AMP; notice lack of sharing buttons.

What I expected

I know AMP is pretty stripped down and doesn't allow scripts and what not, but this might work:
https://www.ampproject.org/docs/reference/components/amp-social-share
https://ampbyexample.com/components/amp-social-share/

@supernovia supernovia added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Sharing Post sharing, sharing buttons AMP labels Oct 12, 2018
@gravityrail
Copy link
Contributor

Interesting. I am not able to reproduce this, at least with AMP 1.0.

@gravityrail
Copy link
Contributor

We should check whether this fixes their issue: #10945

@kristarella
Copy link

I'm not sure if this is the same thing. My user has sharing links that are plain text links and they want them to be icons:
http://cld.wthms.co/9efEQT

My test showing the same type of text links:
http://cld.wthms.co/4k29io

Followup ticket 1697038-zen

@jeherve
Copy link
Member

jeherve commented Jan 7, 2019

@kristarella It does indeed seem like the same issue. This should be fixed in 6.9, scheduled to be released later this week, thanks to #10945

@jeherve jeherve closed this as completed Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMP [Feature] Sharing Post sharing, sharing buttons [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

4 participants