Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post By Email: Support our own shortcode embeds #1259

Closed
aheckler opened this issue Nov 4, 2014 · 8 comments
Closed

Post By Email: Support our own shortcode embeds #1259

aheckler opened this issue Nov 4, 2014 · 8 comments
Labels
[Feature] Post By Email [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@aheckler
Copy link
Member

aheckler commented Nov 4, 2014

We should allow the shortcodes listed here to be used in addition to the existing PBE ones.

Right now, for example, there is literally no way to embed a video in a post using PBE: neither the [youtube] shortcode, the YouTube.com-provided iframe, nor just pasting the URL on it's own line works. :(
@aheckler aheckler added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Post By Email labels Nov 4, 2014
@aheckler
Copy link
Member Author

Forums user with same issue: https://wordpress.org/support/topic/youtube-embed-urls-1

@samhotchkiss
Copy link
Contributor

No good! This should be a pretty easy fix, I'd imagine. Tagging for 3.5

@samhotchkiss samhotchkiss added this to the 3.5 milestone Jan 30, 2015
@aheckler
Copy link
Member Author

@samhotchkiss I can't remember if I tested this on WP.com or not, so it may not work there either. I will have to test and get back to you.

@samhotchkiss
Copy link
Contributor

Either way, it should just require us to make sure we're running the same filters.

@aheckler
Copy link
Member Author

Huh, weird. Now that I test it with a YouTube video, it works fine when you use the shortcode:

[youtube=https://www.youtube.com/watch?v=3d2VnZu70IY]

... but doesn't work when you just insert the link, like so:

https://www.youtube.com/watch?v=3d2VnZu70IY

This is probably expected. It also worked with the Facebook shortcode.

Did we maybe fix this at some point and I missed it? I swear it didn't work when I opened this...

@kevmarsden
Copy link

The same user contacted us in the P2 theme forum. I tested post by email using YouTube both HTTP and HTTPS raw links and found that neither links created a embedded video.

@dereksmart dereksmart modified the milestones: 3.6, 3.7 Jun 25, 2015
@samhotchkiss samhotchkiss modified the milestones: 3.7, Needs Triage Aug 28, 2015
@samhotchkiss
Copy link
Contributor

Our implementation of Post by Email is intended to be very simple and minimal, so, unfortunately, this doesn't align with our development goals and plans at this time, and is not on our roadmap for future development.

@jeherve jeherve modified the milestone: Needs Triage Feb 15, 2016
@richardmtl
Copy link
Contributor

Noting that this came up again here:

https://wordpress.org/support/topic/posts-by-email-and-youtube/

Just using the link did not embed the Youtube video, as described by Adam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Post By Email [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jeherve @samhotchkiss @kevmarsden @richardmtl @aheckler @dereksmart