Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slideshow block: slider doesn't auto-advance on Win 10 computers with animations disabled #14523

Closed
KokkieH opened this issue Jan 30, 2020 · 2 comments
Labels
[Block] Slideshow [Focus] Accessibility Improving usability for all users (a11y) [Status] Wontfix [Type] Bug When a feature is broken and / or not performing as intended

Comments

@KokkieH
Copy link

KokkieH commented Jan 30, 2020

Steps to reproduce the issue

  1. Create a post with a slideshow block and add some images to it.
  2. On a Windows 10 computer, go to Settings ->Display, and under "Simplify and personalize Windows" toggle the "Show animations in Windows" to off.
  3. View the post using any browser

What I expected

For the slider to advance automatically.

What happened instead

The slider doesn't advance, and can only be advanced using the arrow buttons, or the controls below the slider.

Upon toggling the Show animations setting to on and refreshing the page, the slider auto-advances normally.

Reported by users in https://wordpress.org/support/topic/jetpack-slideshow-not-advancing/ and https://wordpress.org/support/topic/slideshow-block-autoplay/

The user in the second thread managed to track the issue down to the line:

.matchMedia("(prefers-reduced-motion: reduce)")

Modifing that line as follows allow the slider to work:

.matchMedia("(prefers-reduced-motion: no-preference)")

Was this added to the block with the intent of respecting this Windows setting in this way, or is this something we might be able to fix?

I found one issue mentioning .matchMedia, #8309, where it was added to improve accessibility regarding the now-deprecated holiday snow feature, so adding the accessibility tag here as well.

@KokkieH KokkieH added [Type] Bug When a feature is broken and / or not performing as intended [Focus] Accessibility Improving usability for all users (a11y) [Block] Slideshow labels Jan 30, 2020
@jeherve
Copy link
Member

jeherve commented Jan 30, 2020

This seems like the expected behaviour. If I were to disable animations in my OS settings, I would expect the slider not to move on its own. I think it's a useful feature for folks who may experience discomfort with moving images.

Closing as won't fix.

@KokkieH
Copy link
Author

KokkieH commented Jan 30, 2020

Thanks for checking. I'll let the user know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Slideshow [Focus] Accessibility Improving usability for all users (a11y) [Status] Wontfix [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

2 participants