Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(3P) Update block categorization in CoBlocks #14598

Closed
4 tasks
obenland opened this issue Feb 7, 2020 · 8 comments
Closed
4 tasks

(3P) Update block categorization in CoBlocks #14598

obenland opened this issue Feb 7, 2020 · 8 comments
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Type] Task

Comments

@obenland
Copy link
Member

obenland commented Feb 7, 2020

As a writer, I'd like blocks to be categorized appropriately, so they are easier for me to find.

Acceptance Criteria:

  • Blocks make use of four new categories: Blog, Earn, Marketing, and Social.
  • Blocks are part of the assigned category.
  • Blocks are not within a "collection" category (meaning "Jetpack" or "Coblocks").

Resources:

Implementation Notes

  • Confirm it's ok to register the same Category twice without causing an error. This is in case Core creates a new Category with the same as ours. (Also can we check for cat exists before creating?).

How to Demo:

  • In the block selector, identify two or three blocks that found their new home in a core-registered or custom category.
  • Show how blocks not make use of "collection" categories anymore.

More discussion: p58i-8yl-p2.

@obenland obenland added [Type] Task [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Feb 7, 2020
@obenland
Copy link
Member Author

obenland commented Feb 7, 2020

@lessbloat We was wondering if there's a list of the blocks this should apply to, that ideally would also include the category and collection they should fall into?

@davemart-in
Copy link
Contributor

I outlined my proposal for 4 collections here. Let's hold off on category changes until this core PR is merged.

@obenland obenland changed the title Ajax: Utilize block collections for better block categorization Ajax: Update block categorization Feb 11, 2020
@obenland
Copy link
Member Author

The issue description was updated and reflects the latest status of this task

@marekhrabe
Copy link
Contributor

Let's make sure newly registered categories (like "Layout") would not cause a fatal error if other plugin or core decides to register the same name.

@retrofox
Copy link
Contributor

retrofox commented Feb 18, 2020

Let's make sure newly registered categories (like "Layout") would not cause a fatal error if other plugin or core decides to register the same name.

Adding a new category with the same slug produces a funny visual bug. Basically, both sections in the accordion will act as a single one. it means if you open one of them, both will be open. Same closing the accordion.
Also, both section containers are filled with the same blocks, which makes sense because the category slug is for both sections.

@retrofox
Copy link
Contributor

retrofox commented Mar 2, 2020

in #14721 I've handled the categories straight in Jetpack. We agreed that it'd be better to handle them in the respective repositories. For instance, for coblocks we should tackle them at https://github.com/Automattic/coblocks-builder, and so on with other blocks.

@retrofox retrofox changed the title Ajax: Update block categorization Update block categorization Mar 3, 2020
@frontdevde
Copy link
Contributor

Let's hold off on category changes until this core PR is merged.

WordPress/gutenberg#19279 still hasn't been merged and it looks like the discussion in core is stalling.

@jeryj jeryj changed the title Update block categorization (5P) Update block categorization Mar 31, 2020
@obenland
Copy link
Member Author

obenland commented Apr 6, 2020

Jetpack side is done, only CoBlocks category update remains

@obenland obenland changed the title (5P) Update block categorization (3P) Update block categorization Apr 6, 2020
@obenland obenland changed the title (3P) Update block categorization (3P) Update block categorization in CoBlocks Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Type] Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants