Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(3P) External Media: Arrow keys not captured by modal #15855

Closed
jeryj opened this issue May 19, 2020 · 2 comments · Fixed by #16055
Closed

(3P) External Media: Arrow keys not captured by modal #15855

jeryj opened this issue May 19, 2020 · 2 comments · Fixed by #16055
Assignees
Labels
[Extension] External Media Extend all block editor media tools to support external providers [Focus] Accessibility Improving usability for all users (a11y) [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jeryj
Copy link
Contributor

jeryj commented May 19, 2020

When using a Media Extensions modal (like Pexels or Google photos), you can press the arrow keys and it will either close the modal or interact with the editor canvas.

Steps to reproduce the issue

Modal closing

  1. Insert an image block
  2. Click on Select Image
  3. Choose "Pexels Free Libary"
  4. See the modal open
  5. Press an arrow key
  6. The modal will close

Interacting with window behind the modal

  1. Insert an image block
  2. Click on Select Image
  3. Choose "Google Libary"
  4. See the modal open
  5. Add a Before or After date filter
  6. Click the Before/After filter button to get the calendar to show
  7. press the arrow keys
  8. Focus is now in the editor canvas. You can tab/arrow key around and see things change behind the modal.

What I expected

Arrow keys should be bound within the modal.

@jeryj jeryj added [Type] Bug When a feature is broken and / or not performing as intended [Extension] External Media Extend all block editor media tools to support external providers [Focus] Accessibility Improving usability for all users (a11y) labels May 19, 2020
@obenland
Copy link
Member

obenland commented Jun 1, 2020

Possible ways:

  • Check the modal if there are ways to better implement ours as these keypresses should be handled by it.
  • Check onClose handlers to see if they're too broad

Let's re-estimate this once we found a way forward.

@obenland obenland changed the title External Media: Arrow keys not captured by modal (3P) External Media: Arrow keys not captured by modal Jun 1, 2020
@WunderBart WunderBart self-assigned this Jun 1, 2020
@WunderBart WunderBart linked a pull request Jun 3, 2020 that will close this issue
@WunderBart
Copy link
Member

Fixed by #16055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Extension] External Media Extend all block editor media tools to support external providers [Focus] Accessibility Improving usability for all users (a11y) [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants