Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Media: Source icons in the wrong spot #17472

Closed
alaczek opened this issue Sep 30, 2020 · 1 comment · Fixed by #17442
Closed

External Media: Source icons in the wrong spot #17472

alaczek opened this issue Sep 30, 2020 · 1 comment · Fixed by #17442
Assignees
Labels
[Extension] External Media Extend all block editor media tools to support external providers [Type] Bug When a feature is broken and / or not performing as intended

Comments

@alaczek
Copy link
Contributor

alaczek commented Sep 30, 2020

We're offering a choice of three different sources for media - browsing the media library, adding photos from Google Photos, or through Pexels. The icons for each option are displayed after the text, which looks really unbalanced and isn't following design standards we have everywhere else in calypso.

Steps to reproduce

  1. Create a new post or a page. Add Image block.
  2. Click the "Select source" option. Notice the icons placement for each of the options.
  3. Insert an image, then select it and click the "Replace" button on the toolbar. Again, notice the icons placement for each of the options.
  4. Compare to the options in the Paragraph block, where all the icons are placed on the left.

Same issues apply to the Gallery block.

Screenshot / Video

image

Image block, replace image options. This one is particularly problematic because some of the icons are aligned to the right, while others are placed right after the text. Also, note that the icon for the media library in this one is different than in the next screenshot.

image

Image block, insert new image through "Select source" option. Compare this to the Paragraph block below:

image

Context / Source

#dogfooding

@alaczek
Copy link
Contributor Author

alaczek commented Sep 30, 2020

The same pattern is being used in the Image block settings too.

image

@WunderBart WunderBart transferred this issue from Automattic/wp-calypso Oct 13, 2020
@WunderBart WunderBart changed the title Media: Media source icons in the wrong spot External Media: Source icons in the wrong spot Oct 13, 2020
@jeherve jeherve added the [Extension] External Media Extend all block editor media tools to support external providers label Oct 13, 2020
@jeherve jeherve added the [Type] Bug When a feature is broken and / or not performing as intended label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Extension] External Media Extend all block editor media tools to support external providers [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants