Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devicepx: add it as a module or a theme tool to avoid confusion #1850

Closed
jeherve opened this issue Mar 24, 2015 · 11 comments · Fixed by #10189
Closed

Devicepx: add it as a module or a theme tool to avoid confusion #1850

jeherve opened this issue Mar 24, 2015 · 11 comments · Fixed by #10189
Labels
General [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@jeherve
Copy link
Member

jeherve commented Mar 24, 2015

Right now, devicepx-jetpack.js is enqueued on your site as soon as you activate Jetpack, and even before you connect your site to your WordPress.com account. There is no mention of it anywhere in the Jetpack menu, and no way to deactivate it without code.

It would be nice to offer an option to disable it from the dashboard, or add it as a theme tool via add_theme_support() so it's not on by default without any mechanism to turn it off.

Suggested here:
https://wordpress.org/support/topic/jetpack-postinf-to-social-profiles-without-permission?replies=3&view=all#post-6733290

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it General labels Mar 24, 2015
@jeherve jeherve added this to the vFuture milestone Mar 24, 2015
@jeherve
Copy link
Member Author

jeherve commented Mar 24, 2015

Related: #804

@georgestephanis
Copy link
Member

Honestly, I really want to just drop devicepx entirely, we just need to get browser native support up first.

@lumpysimon
Copy link

I'm running a high traffic site with only the Protect module activated. We're keen to minimise requests and pageload time, but the devicepx script is loading. This seems completely redundant, as far as I can tell this script is only related to images, nothing at all to do with the Protect module.

@samhotchkiss samhotchkiss modified the milestones: vFuture, Needs Triage Aug 29, 2015
@jeherve jeherve modified the milestones: 4.0, Needs Triage Feb 16, 2016
@jeherve jeherve modified the milestones: 4.1, 4.3 Jun 17, 2016
@richardmuscat richardmuscat modified the milestones: 4.3, 4.4 Jul 7, 2016
@samhotchkiss samhotchkiss modified the milestones: 4.4, Not Currently Planned Nov 9, 2016
@Miaourt
Copy link

Miaourt commented Feb 13, 2017

Any new on disabling this thing ?

@jeherve
Copy link
Member Author

jeherve commented Feb 13, 2017

@Technowix No news, but we'll update this issue when we make progress on this.

In the meantime, you can use the following snippet to disable it on your site:

function jeherve_dequeue_devicepx() {
    wp_dequeue_script( 'devicepx' );
}
add_action( 'wp_enqueue_scripts', 'jeherve_dequeue_devicepx' );

@Miaourt
Copy link

Miaourt commented Feb 13, 2017

Thanks for reply @jeherve , where did I put this little snippet ?

@jeherve
Copy link
Member Author

jeherve commented Feb 13, 2017

You can paste this in your theme's functions.php file, or in a functionality plugin

@webdados
Copy link

So... nothing new on this?

@Miaourt
Copy link

Miaourt commented Oct 19, 2017

Beside having to hack things... Nuh

@webdados
Copy link

@Technowix Surprise, surprise

@stale
Copy link

stale bot commented Jun 30, 2018

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants