Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDC: Inline notice for inability to disconnect staging sites #2627

Closed
kraftbj opened this issue Aug 26, 2015 · 0 comments · Fixed by #3094
Closed

IDC: Inline notice for inability to disconnect staging sites #2627

kraftbj opened this issue Aug 26, 2015 · 0 comments · Fixed by #3094
Assignees
@zinigor
Labels
[Status] Requires String Changes [Type] Bug When a feature is broken and / or not performing as intended
Milestone
3.8.2

Comments

@kraftbj
Copy link
Contributor

kraftbj commented Aug 26, 2015

On the Disconnect Jetpack confirmation prompt, we disable the button on staging sites. However, the change was made too late in 3.7 to get a string in for it.

We cobbled together for 3.7, but let's do a proper notice in 3.7.1.
@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended My Jetpack labels Aug 26, 2015
@kraftbj kraftbj added this to the 3.8 milestone Aug 26, 2015
@kraftbj kraftbj modified the milestones: 3.7.1, 3.8 Aug 26, 2015
@zinigor zinigor self-assigned this Sep 11, 2015
@zinigor zinigor modified the milestones: 3.8, 3.7.1 Sep 17, 2015
@dereksmart dereksmart modified the milestones: 3.8.1, 3.8 Nov 3, 2015
@kraftbj kraftbj modified the milestones: 3.8.1, 3.8.2 Nov 30, 2015
@zinigor zinigor mentioned this issue Dec 2, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zinigor zinigor

Labels
[Status] Requires String Changes [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
3.8.2
Development

Successfully merging a pull request may close this issue.

My Jetpack: added a message about why it is impossible to disconnect. Automattic/jetpack
4 participants
@kraftbj @zinigor @samhotchkiss @dereksmart