Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jetpack Search + WPML] - Search shows results from both languages #32811

Closed
diiegopereira opened this issue Sep 1, 2023 · 1 comment
Closed
Labels
[Feature] Search For all things related to Search [Focus] Compatibility Ensuring our products play well with third-parties [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended [Type] Duplicate

Comments

@diiegopereira
Copy link

diiegopereira commented Sep 1, 2023

Impacted plugin

Search

Quick summary

Hi there, this is Diego from the WPML Compatibility team.

When doing a Jetpack Search on a site with WPML, it will show results for all languages instead of just results in the current language.

We got a report in support for this issue here.

We checked to see if there is anything we could do on the WPML side, but It seems that the content is indexed on the WordPress servers.

When we search on the site, direct REST requests are made to the WordPress server. To fix this, we would need to have different indexes per language or manage to include a language parameter to the search.

Steps to reproduce

  • Setup WPML
  • Setup Jetpack and Jetpack Search
  • Create some posts and translate
  • Go on front and try a search in both languages
  • Both language posts/pages are showing

A clear and concise description of what you expected to happen.

Show results for current language only.

What actually happened

Search results for all languages are displayed instead of just results for the current language.

Impact

Some (< 50%)

Available workarounds?

No

Platform (Simple and/or Atomic)

Self-hosted

Logs or notes

No response

@diiegopereira diiegopereira added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Sep 1, 2023
@github-actions github-actions bot added [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Pri] BLOCKER [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack labels Sep 1, 2023
@john-legg john-legg added [Pri] Normal and removed [Pri] BLOCKER [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack labels Sep 1, 2023
@jeherve jeherve added [Feature] Search For all things related to Search [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Package] Search Contains core Search functionality for Jetpack and Search plugins [Focus] Compatibility Ensuring our products play well with third-parties and removed Needs triage Ticket needs to be triaged labels Sep 4, 2023
@jeherve
Copy link
Member

jeherve commented Sep 4, 2023

Thanks for the report. This is currently tracked in #8766.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search For all things related to Search [Focus] Compatibility Ensuring our products play well with third-parties [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended [Type] Duplicate
Development

No branches or pull requests

3 participants