Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AI Assistant: Fix selected block while using the AI Assistant extension on a nested block #37519

Merged
merged 4 commits into from
May 24, 2024
Merged

AI Assistant: Fix selected block while using the AI Assistant extension on a nested block #37519

merged 4 commits into from
May 24, 2024

Conversation

dhasilva
Copy link
Contributor

Fixes #37518

Proposed changes:

  • Adds the blockProp's className to the input, so both elements have the same className and are understood by the editor to be part of the same block when nested.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to the block editor
  • Add a Columns block with a column in it
  • Add an extended block inside the column (a Heading or Paragraph)
  • Use the Ask AI Assistant toolbar action to open the input
  • Check that the input stays open and the toolbar does not change

A video comparison for reference:

Before:

Peek.2024-05-23.14-52.mp4

After:

Peek.2024-05-23.14-55.mp4

@dhasilva dhasilva added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Block] AI Assistant [Extension] AI Assistant labels May 23, 2024
@dhasilva dhasilva requested a review from a team May 23, 2024 18:06
@dhasilva dhasilva self-assigned this May 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 23, 2024 •
edited

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/ai-assistant-inline-extension-nested-input branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/ai-assistant-inline-extension-nested-input

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label May 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for June 4, 2024 (scheduled code freeze on June 3, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

lhkowalski
lhkowalski approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@lhkowalski lhkowalski left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and is testing as expected for the presented use case.

The AI Control appears on the right place and stays open:

Screenshot 2024-05-24 at 11 29 24

It's also working with multiple columns:

Screenshot 2024-05-24 at 11 30 50 . Screenshot 2024-05-24 at 11 31 00

I got a buggy position when testing with rows inside a group, we can keep iterating on this:

Screenshot 2024-05-24 at 11 34 36

@dhasilva dhasilva merged commit 623d749 into trunk May 24, 2024
57 checks passed
@dhasilva dhasilva deleted the fix/ai-assistant-inline-extension-nested-input branch May 24, 2024 14:49
@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label May 24, 2024
@github-actions github-actions bot added this to the jetpack/13.5 milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhkowalski lhkowalski lhkowalski approved these changes

Assignees

@dhasilva dhasilva

Labels
[Block] AI Assistant [Extension] AI Assistant [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Milestone
jetpack/13.5
Development

Successfully merging this pull request may close these issues.

AI Assistant: Fix inline extension on nested blocks
2 participants
@dhasilva @lhkowalski