Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common CSS class names like "contact-form" should be more specific to Jetpack #5876

Open
alexjgustafson opened this issue Dec 14, 2016 · 5 comments
Open

Common CSS class names like "contact-form" should be more specific to Jetpack #5876

alexjgustafson opened this issue Dec 14, 2016 · 5 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Contact Form Good For Community [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@alexjgustafson
Copy link

We have some CSS class names that can cause interference with theme developers:

.contact-form
.button
.presentation

Other CSS classes have names like .jp-relatedposts , or .jp-carousel - could we scrub some of the more common phrases and use the 'private' phrases instead?

2958461-t
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Pri] Low labels Dec 15, 2016
@jeherve jeherve added this to the Community milestone Dec 15, 2016
@samhotchkiss samhotchkiss modified the milestones: Community, Not Currently Planned Feb 10, 2017
@rclations rclations mentioned this issue Sep 28, 2017
Merged
@jeherve
Copy link
Member

jeherve commented Mar 2, 2018

Also in https://wordpress.org/support/topic/jetpack-css-trumps-mine/

@jeherve jeherve removed this from the Not Currently Planned milestone Mar 2, 2018
@stale
Copy link

stale bot commented Sep 17, 2018

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Sep 17, 2018
@jeherve
Copy link
Member

jeherve commented Jan 19, 2021

Related: #18404

@stale stale bot removed the [Status] Stale label Jan 19, 2021
@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Jan 19, 2021
@jeherve jeherve mentioned this issue Jan 19, 2021
Closed
@jeherve
Copy link
Member

jeherve commented May 11, 2021

Also in https://wordpress.org/support/topic/jetpack-contact-form-7-2/

@danjjohnson
Copy link

Also in https://wordpress.org/support/topic/jetpack-css-overrides-custom-styles-and-cf7-plugin-rules/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Contact Form Good For Community [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jeherve @samhotchkiss @alexjgustafson @danjjohnson @matticbot