Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcode Embeds: Instagram oEmbeds not displaying properly in wp-admin editor #7690

Closed
emrikol opened this issue Aug 24, 2017 · 3 comments
Closed
Labels
[Feature] Shortcodes / Embeds [Type] Bug When a feature is broken and / or not performing as intended [Type] Duplicate

Comments

@emrikol
Copy link
Contributor

emrikol commented Aug 24, 2017

Steps to reproduce the issue

Enable "Shortcode Embeds" and add an Instagram oEmbed (ex: https://www.instagram.com/p/BYMDTB5g95n/)

What I expected

I expect to see the rendered embed in the editor:

image

What happened instead

Instead, I see a broken Instagram embed:

image

This can also be fixed by removing the Jetpack embed provider and re-adding the core provider, in a pinch:

add_action( 'init', 'add_core_oembed_provider' );
function add_core_oembed_provider() {
    wp_embed_unregister_handler( 'jetpack_instagram' );
    wp_oembed_add_provider( '#https?://(www\.)?instagr(\.am|am\.com)/p/.*#i', 'https://api.instagram.com/oembed', true );
}
@jeherve jeherve added [Feature] Shortcodes / Embeds [Type] Bug When a feature is broken and / or not performing as intended labels Sep 8, 2017
@stale
Copy link

stale bot commented Jul 2, 2018

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Jul 2, 2018
@BrookeDot
Copy link
Contributor

We are also seeing this with WordPress 5.3 with the Block Editor enabled. As with WP-Admin disabling jetpack_instagram and re-enabling core's provider does workaround the problem.

@stale stale bot removed the [Status] Stale label Mar 12, 2020
@jeherve
Copy link
Member

jeherve commented Mar 13, 2020

Good point. I'll close this issue in favor of #9331, where we track the issue within the Block editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Shortcodes / Embeds [Type] Bug When a feature is broken and / or not performing as intended [Type] Duplicate
Projects
None yet
Development

No branches or pull requests

3 participants