Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Likes: Individual page Likes settings not respected when page is displayed outside the main query #9002

Open
sixhours opened this issue Mar 7, 2018 · 4 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Likes [Pri] Low [Status] Stale [Type] Bug When a feature is broken and / or not performing as intended

Comments

@sixhours
Copy link
Contributor

sixhours commented Mar 7, 2018

Originally reported in Automattic/themes#13

Steps to reproduce the issue

In Shoreditch:

  1. Activate Shoreditch
  2. Make sure like buttons for the site are turned on globally under My Site > Sharing
  3. Create a page with the Panel Page template
  4. Give that page a few child pages and make sure the Like button is turned off for each individual Child Page
  5. View the parent Panel Page - like buttons appear on the child panels

A similar instance in Affinity:

  1. Activate Affinity.
  2. Make sure like buttons for the site are turned on under My Site > Sharing.
  3. Create a couple of Pages, and turn Likes off for those pages.
  4. Set a Static Front Page under Customize -> Homepage Settings.
  5. Go to Customize -> Theme Options -> Panel 1 and select one of the pages created in step 3.
  6. Go to Customize -> Theme Options -> Panel 2 and select the other page created in step 3.
  7. Publish changes and view your home page. The Likes settings for the individual child pages are not respected; you'll still see Likes enabled, even though they've been turned off for those child pages.

What I expected

Likes should respect the individual page/post settings before falling back to the global settings, even though the pages are displayed in a separate query.

What happened instead

Likes are shown according to the global settings, ignoring the individual page/post settings when displayed outside the main query.

We're working around this with Custom CSS to hide unwanted Likes for now.

Follow-up information:

@stale
Copy link

stale bot commented Sep 3, 2018

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Sep 3, 2018
@formosattic
Copy link

formosattic commented Oct 30, 2018

User report with Shoreditch (7642824-hc, 1529468-zen)

CSS workaround to hide Like button only on pages with Panel Template:

.page-template-panel-page .sharedaddy {
     display: none;
}

@stale stale bot removed the [Status] Stale label Oct 30, 2018
@stale
Copy link

stale bot commented Apr 28, 2019

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Apr 28, 2019
@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Apr 28, 2019
@stale stale bot removed the [Status] Stale label Apr 28, 2019
@stale
Copy link

stale bot commented Oct 25, 2019

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Likes [Pri] Low [Status] Stale [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

4 participants