Replace deep-extend with nested Object.assign #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrit
approved these changes
Jul 1, 2020
|
can you resolve the merge conflict? the rest looks good |
deep-extend is only used to handle one nested options object. In this diff I replaced dependency with native Object.assign and handled "webResources" as special case similar to special case in cli options definitions.
TrySound
force-pushed
the
drop-deep-extend
branch
from
1b6c17e
to
7116879
Compare
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deep-extend is only used to handle one nested options object.
In this diff I replaced dependency with native Object.assign and handled
"webResources" as special case similar to special case in cli options
definitions.