Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress doesn't work anymore #182

Open
tj opened this issue May 24, 2013 · 6 comments
Open

progress doesn't work anymore #182

tj opened this issue May 24, 2013 · 6 comments

Comments

@tj
Copy link
Contributor

tj commented May 24, 2013

the counter-stream thing is broken, it gets events very quickly and does not represent the real upload, just doing:

  stream.pipe(req);
  stream.on('data', function(c){
    console.log(c.length);
  });

gives me the real results again

@domenic
Copy link
Contributor

domenic commented Jun 9, 2013

Hmm I just ran a test and it works really well for me. Are you on Node 0.10? Maybe the Node 0.8 streams2 polyfill we're using doesn't emulate this correctly?

@tj
Copy link
Contributor Author

tj commented Jun 12, 2013

we're on 0.8.x still unfortunately :s

@domenic
Copy link
Contributor

domenic commented Jun 12, 2013

Ah OK :-/. @superjoe30 if you feel up for it tracking down what makes stream-counter fail on 0.8.x + streams2 polyfill that would be superb...

@andrewrk
Copy link
Contributor

Sounds like a bug with https://github.com/isaacs/readable-stream. Best thing to do would be to create a failing test case and make an issue on that project. stream-counter uses the API that was recommended by the node devs.

@gh-naylor
Copy link

Is this still an open issue? I'm having trouble with the progress event, but I'm not sure if it's just my code or a valid bug.

@chanadian
Copy link

On certain uploads I see that the progress events will think it is writing more than 100% of data. It seems that the written matches the file size, but total is incorrect, which leads to over 100% progress. Example:

Events: [{"percent":99,"written":65536,"total":65920,"time":"2015-09-18T22:55:13.296Z"},{"percent":109,"written":71864,"total":65920,"time":"2015-09-18T22:55:13.305Z"}]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants