Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipart upload #89

Closed
domenic opened this issue Sep 10, 2012 · 7 comments
Closed

Multipart upload #89

domenic opened this issue Sep 10, 2012 · 7 comments
Labels

Comments

@domenic
Copy link
Contributor

domenic commented Sep 10, 2012

Consider adding support for the multipart upload API. See #17 and #50 for stale pull requests.

We still need to determine what the API would be, how much it would change or add to Knox, and whether it's in scope for Knox or should perhaps be a different package.

@domenic
Copy link
Contributor Author

domenic commented Sep 22, 2012

@joehoyle
Copy link

+1, after trying to upload a 15GB file, I stumbled on this issue :)

Is there anyway I can work around this / hack something together with knox?

@domenic
Copy link
Contributor Author

domenic commented Oct 24, 2012

I mean, you can use client.request() to send raw requests of any kind to S3, and using that you could fulfill the algorithm outlined in that StackOverflow answer.

And then, of course, you could make sure that code was sufficiently general, and submit it as a pull request to Knox! :)

@lazdmx
Copy link

lazdmx commented Oct 31, 2012

+1 vote

@nathanoehlman
Copy link

I've written a standalone module (knox-mpu) that uses knox to provide multipart uploads to S3. It's got a few features missing at the moment, but does the job.

If you guys are interested, I'll add it to knox and submit a pull request.

@domenic
Copy link
Contributor Author

domenic commented Nov 1, 2012

@nathanoehlman Oh awesome! I'll check it out soon. I'd lean toward keeping it a separate package and linking to it from the readme, but maybe there'd be value in transparently switching to MPU for certain cases.

@nathanoehlman
Copy link

@domenic Yep - those were my thoughts exactly. I originally had it in Knox but it didn't feel like it quite belonged (hence the separate module) so I figured I'd just leave the decision as to where it belonged to you guys :)

@domenic domenic closed this as completed Nov 1, 2012
domenic added a commit that referenced this issue Nov 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants