-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Round out polling timestamp #496
Conversation
Rather than a random scatter of timestamps, we can get a much higher cache hit-rate by forcing/normalizing multiple clients to make a request with the same timestamp.
575aee2
to
779c23f
Compare
Lint issues have been fixed. |
Per @rogertheriault, this can result in timestamps in the future. Change |
I made @paulschreiber / @rogertheriault's suggested change and then ran a test. I took a simple Liveblog, opened it on 3 different clients (using different IPs) and proceeded to add new entries. I then looked at the API requests that came in from those clients. What I saw was multiple clients using the same URLs, with clear 10-second intervals and the start time updating only occassionally. I have listed these request URLs below with readable start and end times.
As is clear, after request no. 4 the start time changes. After the test, I used Looks like, with the |
We've (@mjangda actually) noticed that |
I was told to remove |
I've pushed the removal of the |
Rather than a random scatter of timestamps, we can get a much higher cache hit-rate by forcing/normalizing multiple clients to make a request with the same timestamp.