Embedded Documents don't have methods defined on their schema

[lukegalea]

var ObservationSchema = new Schema({
  an_array:  { type: Array , default: ['a'] }  
});

ObservationSchema.method('a_method', function() {
  return 'something';
});

mongoose.model('Observation', ObservationSchema);
var Observation = mongoose.model('Observation');

var ContainerSchema = new Schema({
  observations: [ObservationSchema]
});

mongoose.model('Container', ContainerSchema);
var Container = mongoose.model('Container');

var o = new Observation();
console.log(o.a_method()); // This works

var c = new Container();
c.observations.push({});

console.log(c.observations[0].a_method()); // This doesn't

[lukegalea]

Could anyone point me in the right direction to a fix for this? I'm happy to try and fix it myself.. My code is totally dead in the water right now without this working.

Thanks in advance!

[lukegalea]

Ahh.. belay that. It looks like you can use virtuals and gets.. but methods defined via "method" don't work. So I can work around it for now. Thanks.

[justmoon]

Here is a patch:

diff --git a/lib/mongoose/schema/documentarray.js b/lib/mongoose/schema/documentarray.js
index 31fb3f8..6ce7665 100644
--- a/lib/mongoose/schema/documentarray.js
+++ b/lib/mongoose/schema/documentarray.js
@@ -29,6 +29,10 @@ function DocumentArray (key, schema, options) {
   EmbeddedDocument.prototype.schema = schema;
   EmbeddedDocument.schema = schema;

+  // apply methods
+  for (var i in schema.methods)
+    EmbeddedDocument.prototype[i] = schema.methods[i];
+
   ArrayType.call(this, key, EmbeddedDocument, options);

   var self = this;

Performance-wise this could be improved by creating the EmbeddedDocument during module compilation.

[bentruyman]

+1 to see this get fixed.

Instead of patching DocumentArray, I've been doing the following until the fix (hopefully) lands:

embeddedDoc.__proto__._schema.methods.myMethod.apply(embeddedDoc, [args]);

[jimpo]

This seems to no longer work.

[aheckmann]

@jep37 please open a new ticket with a failing test case. include which mongoose version in use

[jimpo]

Nevermind, I didn't realize you had to define the methods on the embedded schema before defining the parent schema.