Promise not rejected on CastError

[gvelo]

There is a inconsistent behavior in the API related to error handling on callback vs promise flow.

In the following code, onRejected is never called and a MongooseError ( CastError ) is thrown

doc.update(  { _id: 'foo' }, {  $push:{ bar: value} } ).then( onFulfilled , onRejected )

But in the callback variant the callback function is called properly with the error.

doc.update(  { _id: 'foo' }, {  $push:{ bar: value} },  callback )

[vkarpov15]

Thanks for pointing this out, will fix.

[vkarpov15]

So this would qualify as a backwards breaking change, because I would imagine some people still do

try {
  query = Model.update({ _id: 'foo' });
} catch(err) {}

query.exec();

because that's part of mongoose's API. That will change in 5.0, however, till then,

doc.update(  { _id: 'foo' }, {  $push:{ bar: value} }, { dontThrowCastError: true } ).then( onFulfilled , onRejected )

is the best we can do for 4.2.4 unfortunately.