fix(document): correct context for default functions in subdocuments with init #12427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12328
Summary
#12328 pointed out that, when initializing a subdocument, we call default functions before applying the initial property values. This is problematic for default functions.
Looks like easy fix: just skip applying defaults when creating the empty object, and let
init()
apply defaults.Still one failing test case though that I need to fix, thought I had fixed it but guess not.
Examples