Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2833 added condition to check for undefined value #2834

Closed
wants to merge 2 commits into from
Closed

#2833 added condition to check for undefined value #2834

wants to merge 2 commits into from

Conversation

winfinit
Copy link

@winfinit winfinit commented Apr 2, 2015

wrapped timestamp support around IF to check for undefined values

@winfinit winfinit mentioned this pull request Apr 2, 2015
Closed
@winfinit
Copy link
Author

winfinit commented Apr 5, 2015

failure that was reported by travis before, was not attributed to this change.

@vkarpov15
Copy link
Collaborator

This issue doesn't affect master, see L209 in schema/date.js and #2272. Also please don't do things like 6aee997, that's entirely unnecessary. Tests are somewhat flakey on travis, no need to retrigger with another unnecessary commit.

@vkarpov15 vkarpov15 closed this Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winfinit @vkarpov15