Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct carousel button styles in editor #1680

Merged
merged 1 commit into from Mar 1, 2024
Merged

fix: correct carousel button styles in editor #1680

merged 1 commit into from Mar 1, 2024

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR fixes a minor display issue with the Post Carousel block in the editor.

See 1200550061930446-as-1206209020023321

How to test the changes in this Pull Request:

  1. Add a Post Carousel block to the editor, and enable AutoPlay (so the play/pause button appears over the carousel).
  2. Publish the page and compare the editor to the front-end -- note that the previous/next buttons in the editor look weird, and the play/pause buttons are not styled at all, and appear above the slideshow on the left:

image

  1. Apply the PR and run npm run build.
  2. Confirm that the buttons in the editor match the appearance of the front-end; as part of this, pause the slideshow in the editor and confirm it displays a normal looking play button instead of the pause button:

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford requested a review from a team as a code owner February 27, 2024 19:01
@laurelfulford
Copy link
Contributor Author

Thanks Raz!

@laurelfulford laurelfulford merged commit d4aba73 into trunk Mar 1, 2024
8 checks passed
@laurelfulford laurelfulford deleted the fix/carousel-prev-next-styles branch March 1, 2024 23:17
@laurelfulford laurelfulford restored the fix/carousel-prev-next-styles branch March 1, 2024 23:17
@laurelfulford laurelfulford deleted the fix/carousel-prev-next-styles branch March 1, 2024 23:17
matticbot pushed a commit that referenced this pull request Mar 7, 2024
@semantic-release-bot
chore(release): 3.0.4-alpha.1 [skip ci]
ea57f9f 
## [3.0.4-alpha.1](v3.0.3...v3.0.4-alpha.1) (2024-03-07)

### Bug Fixes

* correct carousel button styles in editor ([#1680](#1680)) ([d4aba73](d4aba73))
* **modal-checkout:** ensure customer location when state is required but country is not ([#1683](#1683)) ([27badf8](27badf8))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.0.4-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Mar 7, 2024
@semantic-release-bot
chore(release): 3.0.5-alpha.1 [skip ci]
9c1d0fe 
## [3.0.5-alpha.1](v3.0.4...v3.0.5-alpha.1) (2024-03-07)

### Bug Fixes

* **author-profile:** only display guest author profile when linked ([#1688](#1688)) ([ee1bb21](ee1bb21))
* correct carousel button styles in editor ([#1680](#1680)) ([d4aba73](d4aba73))
* **modal-checkout:** ensure customer location when state is required but country is not ([#1683](#1683)) ([27badf8](27badf8))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.0.5-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Mar 25, 2024
@semantic-release-bot
chore(release): 3.0.5 [skip ci]
d2ff113 
## [3.0.5](v3.0.4...v3.0.5) (2024-03-25)

### Bug Fixes

* **author-profile:** only display guest author profile when linked ([#1688](#1688)) ([ee1bb21](ee1bb21))
* correct carousel button styles in editor ([#1680](#1680)) ([d4aba73](d4aba73))
* **modal-checkout:** ensure customer location when state is required but country is not ([#1683](#1683)) ([27badf8](27badf8))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.1.0-epic-ras-acc.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chickenn00dle chickenn00dle chickenn00dle approved these changes

Assignees
No one assigned
Labels
released on @alpha released on @epic/ras-acc released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@laurelfulford @matticbot @chickenn00dle