fix(author-profile): only display guest author profile when linked

[chickenn00dle]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Closes 0/1206709674365921/1205704843507324/f

This PR addresses an issue where it was possible to select a WP user account that was linked to a guest author account in the author profile block. Previously we weren't correctly filtering out linked WP users in the block whenever a search term was input that matched the WP user but not the linked guest author.

This PR fixes this by changing the strategy for fetching authors to first fetch only unlinked guest authors, then fetch users, and finally swap out any linked WP users with their respective guest author accounts.

How to test the changes in this Pull Request:

1. With Co-Authors Plus installed, add some guest authors and link them to some WP users that are at least author roles. Make sure you also have some unlinked authors as well. Also make sure the names are very different from one another (i.e. I Am Author / The Best Guest)
2. Add an Author Profile block to any page and search for a linked WP author. Confirm there are no results in the suggestion dropdown and you cannot select the linked WP author.
3. Now search for the corresponding guest author. Confirm the author does appear in the dropdown and is selectable.
4. Confirm the correct Guest Author info appears in the block in both the editor and site front end.
5. Repeat the above steps for a non-linked author and confirm you are able to select this account as well
6. Do some additional smoke tests with other accounts with different naming similarity levels (i.e. Test Author / Test Guest Author)

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1205704843507324

[matticbot]

🎉 This PR is included in version 3.0.5-alpha.1 🎉

The release is available on:

• npm package (@alpha dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 3.0.5 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 3.1.0-epic-ras-acc.3 🎉

The release is available on:

• npm package (@epic/ras-acc dist-tag)
• GitHub release

Your semantic-release bot 📦🚀